[Form] Allow setting custom message, adapt to sf2.1 API #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Perfect. |
willdurand
added a commit
that referenced
this pull request
Nov 5, 2012
[Form] Allow setting custom message, adapt to sf2.1 API
|
Thank you! |
|
No problem. You want me to make separate PRs for 2.0 and master or you'll merge this yourself ? |
|
Na. It's ok. Do you work with the 2.0 branch? William Durand | http://www.williamdurand.fr On Mon, Nov 5, 2012 at 2:22 PM, Marek Kalnik notifications@github.comwrote:
|
|
No, unfortunately only 1.1 ATM. |
|
Any idea when Packagist will pick up the 1.1.4 tag, am keen to get on working with it..... |
|
Done :) |
|
Many thanks :D |
|
I think the original namespacing was correct. |
|
Argh, you're right! My mistake! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows setting the message by using 'message' option.
It contains also a refactoring to adapt the code to recent Symfony forms API changes (removes dependency on deprecated functions).
It fixes #160.
The PR should be safe to merge into 1.1 and 2.0 (do you want me to make a separate PR?).
Also note that the namespace is not conform with Symfony2 namespaces (should be Constraint rather than Constraints) but I didn't touch it to avoid BC breaks.